[v24.3.x] Fixed race condition in disk_log_impl::truncate_prefix
#24282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added log entry showing a next offset used to initialize log appender. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit b0c152d)
Fixed a race condition which may lead to a situation in which the same offset was assigned to two different records appended to the log. The race condition was happening when one one fiber was appending batches to the log while the other one was prefix truncating it. (Raft does it when taking a snapshot). In this situation it might happened that the batches were appended to the segment which was about to be deleted in `remove_segment_permanently`. This lead to a situation in which an appended batch was lost and the same offset was assigned to the next one. This lead to assertion triggered in `mux_state_machine` Fixes: Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 189098d)
Added a test validating concurrent operations of writing and prefix truncating a log. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 3a9d721)
Removed the line that informed the user about outstanding locks keeping the segment alive as now the lock is cleared before the segment is closed. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 09feb36)
mmaslankaprv
approved these changes
Nov 25, 2024
|
the below tests from https://buildkite.com/redpanda/redpanda/builds/58690#019363d2-176c-46fe-8e5e-55e20f2edf70 have failed and will be retried |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/58690#01936413-8f46-4952-99dc-dedae44a295c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #21324
Fixes: #24280,