Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unreadable text in the app settings after updating to 0.16 #104

Closed
KingNothing81 opened this issue Jun 10, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@KingNothing81
Copy link

KingNothing81 commented Jun 10, 2024

Device

Other

Device name

Shield TV

Android Version

Android TV 11

App version

0.16

Script version

4.7.0

WebView name and version

Chrome 125.x

Reproduction Steps

Since updating to version 0.16, most text in the app settings window is not readable anymore, as it’s shown dark on a dark background.

PNG-Bild2

I guess this was caused by adding the option to switch between a light and dark theme. And the app seems to use the light theme on Android TV now. As dialog boxes like this have a white background now, but had a dark one before the update.

PNG-Bild

Android TV doesn’t have a system wide setting to choose between a light and dark theme as your default. So sideloaded apps that support both, will always default to using the light theme on Android TV.

So I think the easiest solution would be to enforce the dark theme on Android TV. Or if you like, to also show the theme option in the app settings on Android TV. So Android TV users could also switch between a light and dark theme.

@KingNothing81 KingNothing81 added the bug Something isn't working label Jun 10, 2024
@redphx
Copy link
Owner

redphx commented Jun 10, 2024

Fixed in 0.16.1

@redphx redphx closed this as completed Jun 10, 2024
@KingNothing81
Copy link
Author

KingNothing81 commented Jun 10, 2024

Thanks for the quick fix. But now the settings window also has a white background. With no option to change back to the dark theme.

PNG-Bild

I really preferred the dark background and app dialogs. Especially for TVs I think it’s always better to keep UI’s dark. The light theme is just too bright for the big screen in my opinion.

But it’s a matter of taste of course. That’s why I suggested to also show the theme option in the app settings on Android TV. So users can decide for themselves. But if you don’t want to do that, I hope you can consider to use a dark theme on Android TV again.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants