-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing the latest version of this package results in yarn warnings about workspaces #1815
Comments
Initially filed this against redux-devtools (reduxjs/redux-devtools#854), but the author there directed me to file the issue here. The
|
Looks like this is caused by #1751. I guess they expect the top level workspace not to be published. Kind of a crappy requirement, IMHO. Maybe we can stripe this during publishing somehow? |
Huh, that's... weird. And annoying. (Technically the problem would be #1810 for the Well, couple options. The "workspaces" thing was only to add the docs folder so it all gets installed at once. Easy enough to drop that. Alternately, we could do some silly "rewrite the package file before publishing" shenanigans or something. |
Any solution for this issue? |
@obaydmir Not exactly. We'd need to switch back to having the docs not be a "workspace", and do a new release. We're busy with a lot of other stuff atm and fixing this is not a high priority, especially given that it's just a single warning on install for a smaller portion of the userbase. |
I understand. No pressure. Not really a dealbreaker issue, just wanted to know the status. The info you have to send will place it in context and manage the expectations. We will have to wait for the perfect solution. |
I just published 7.2.6, which removes the workspace and should get rid of the warning. |
Thank you so much! Certainly wasn't expecting it to be fixed so quickly, but it's much appreciated. |
c'mon Tim now no one's gonna believe anything I say about scheduling or task prioritization if you keep fixing things this fast |
@Gaphell Per above, this should have been fixed in 7.2.6. What version do you have installed? |
@markerikson, my bad, I was using 7.2.5. Thanks. |
What version of React, ReactDOM/React Native, Redux, and React Redux are you using?
What is the current behavior?
What is the expected behavior?
No warnings.
Which browser and OS are affected by this issue?
No response
Did this work in previous versions of React Redux?
The text was updated successfully, but these errors were encountered: