shallowEqual breaks typed selector return type

[justgowa]

What version of React, ReactDOM/React Native, Redux, and React Redux are you using?

• React: 18.2.0
• ReactDOM/React Native: 18.2.0
• Redux: 4.2.0
• React Redux: 8.0.4

What is the current behavior?

without shallowEqual type inferred correctly

otherwise it breaks

What is the expected behavior?

types infer correctly with shallowEqual

Which browser and OS are affected by this issue?

No response

Did this work in previous versions of React Redux?

• Yes

[justgowa]

#1348 found related issue

[phryneas]

Could you try installing the CodeSandbox preview build from #1965 and see if that fixes it for you?

(go to https://ci.codesandbox.io/status/reduxjs/react-redux/pr/1965 and follow the install instructions)

[justgowa]

Unfortunally no but useSelector still has same type

I mean NoInfer is not used

When i dive into useSelector.d.ts i see

export declare const useSelector: <TState = unknown, Selected = unknown>(selector: (state: TState) => Selected, equalityFn?: EqualityFn<Selected> | undefined) => Selected;

Then i tryed to add NoInfer type here and is still didn't work.

---

I realised I'm using TypedUseSelectorHook, then went to its type declaration and added NoInfer.

export interface TypedUseSelectorHook<TState> {
    <TSelected>(selector: (state: TState) => TSelected, equalityFn?: EqualityFn<NoInfer<TSelected>>): TSelected;
}

Voila, It's working now

[phryneas]

Ah, very good catch, that one needs it too!
I updated the PR - is it working out of the box for you now?

[justgowa]

Yes, thanks a lot

[justgowa]

@phryneas will you release these changes?

[phryneas]

We'll need a few type tests for that before @markerikson pulls the lever on that - I'll try to get to that in the next few days. Meanwhile, that CI build should work nicely I hope?

[markerikson]

Hmm. Fwiw I just tried setting up a typetest based on this and #1348 , and it seems to be working correctly without NoInfer.

@justgowa by any chance do you have any of TS's "strict" settings turned off?

I'm okay with shipping the change because I don't think it will hurt, but after a quick try I can't repro the original issue.

[markerikson]

Fixed by #1965 .

[justgowa]

@markerikson yep, ts strict is off

[phryneas]

@justgowa we cannot make any guarantees for any TypeScript configuration other than strict: true. We already support the last 5 TypeScript releases.
With all the flags that could be enabled or disabled on top of that, there would be tens of thousands of configuration combinations we have to check.
Also: TypeScript is meant to be used with strict. The fact that you can turn that off is pretty much a backwards compatibility stunt or for during a migration to TS, but you should always aim for enabling strict.

[justgowa]

@phryneas i get it, i'm working on pretty old project and unfortunatly it started with non strict rules.
Anyway, thank you a lot!