-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to resolve module react-dom #2099
Comments
This is probably a result of the ESM packaging updates. We used to have separate Looking into this, but I don't use RN myself - may need some help testing out fixes! |
@talaikis can you provide a repo project that reproduces this issue? |
I was able to repro the issue and the (hopeful) fix is live in 9.0.1. Can you let us know if that works? |
Hi @markerikson, this issue occurs for me when testing (my React Native project) via jest. Since jest needs CJS, it ignores |
@TheWirv : not immediately. Going to need some time to think through the possible ramifications here, unfortunately :( |
No problem at all, I didn't really expect you to automagically come up with a solution. Thank you very much for reopening. |
That PR actually fixes my issues completely. The app works perfectly fine, and the tests are all green. 👌🏼 |
@TheWirv okay, that's very helpful feedback, thank you! I'll probably release that shortly. |
Good morning. I got confirmation that this problem has been solved by newly released v9.0.3. Thanks so much for the fix on such short notice. :) |
What version of React, ReactDOM/React Native, Redux, and React Redux are you using?
What is the current behavior?
Unable to resolve module react-dom
What is the expected behavior?
No react-dom in react-native
Which browser and OS are affected by this issue?
No response
Did this work in previous versions of React Redux?
The text was updated successfully, but these errors were encountered: