Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to React 19 #2172

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from
Draft

Migrate to React 19 #2172

wants to merge 25 commits into from

Commits on Nov 11, 2024

  1. Update React and React-DOM to the new rc version

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fa5a606 View commit details
    Browse the repository at this point in the history

  2. Set @types/react and @types/react-dom to temporary types packages 

    - We set the `@types/react` and `@types/react-dom` package resolutions to `npm:types-react` and `npm:types-react-dom` according to the React 19 migration guide.
    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ae5bc1c View commit details
    Browse the repository at this point in the history

  3. Run tests against different versions of React during CI

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7b0f265 View commit details
    Browse the repository at this point in the history

  4. Remove the now deprecated react-test-renderer package

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    4974788 View commit details
    Browse the repository at this point in the history

  5. Replace the now removed ReactDOM methods 

    - `ReactDOM.render` and `ReactDOM.unmountComponentAtNode` have been removed in React 19. This commit replaces their usage with `rtl.render` and `rtl.cleanup` as recommended in the React 19 migration guide.
    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    478c92b View commit details
    Browse the repository at this point in the history

  6. Replace @testing-library/react-hooks with @testing-library/react 

    - The `renderHook` method in `@testing-library/react-hooks` has now been moved to `@testing-library/react`. This commit updates imports and usages of the `renderHook` function to comply with the new syntax requirements in the [react-hooks-testing-library migration guide](https://github.com/testing-library/react-hooks-testing-library/blob/chore/migration-guide/MIGRATION_GUIDE.md#waitfornextupdate).
    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    9a319a4 View commit details
    Browse the repository at this point in the history

  7. Update react-is implementation 

    - `react-is` has changed the `REACT_ELEMENT_TYPE` symbol from `'react.element'` to `'react.transitional.element'`. We want our changes to be non-breaking and backwards-compatible so we conditionally set the `REACT_ELEMENT_TYPE` based on the detected version of React.
    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    cf93795 View commit details
    Browse the repository at this point in the history

  8. Export IS_REACT_19 and re-use in tests

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7fcc65f View commit details
    Browse the repository at this point in the history

  9. Update wrapper props in useDispatch.spec.tsx to resolve type error

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7f28716 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary rtl.cleanup calls 

    - According to `@testing-library/react` docs, the `cleanup` function is called automatically during the `afterEach` hook and there is no need to manually call it.
    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    9a672f5 View commit details
    Browse the repository at this point in the history

  11. Add @ts-ignore for type issue related to @types/react ^18.61

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    827daba View commit details
    Browse the repository at this point in the history

  12. Uncomment type test

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    676b1fe View commit details
    Browse the repository at this point in the history

  13. Add TODO comment about different rendering behaviors in React 18 vs 19

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    bbd7fc8 View commit details
    Browse the repository at this point in the history

  14. Update react and @types/react in peerDependencies

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    33a5ac5 View commit details
    Browse the repository at this point in the history

  15. Bump use-sync-external-store to the new rc

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fa04a52 View commit details
    Browse the repository at this point in the history

  16. Use types-use-sync-external-store for @types/use-sync-external-store

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    338c82e View commit details
    Browse the repository at this point in the history

  17. Fix skipped tests in ssr.spec.tsx

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    11934c2 View commit details
    Browse the repository at this point in the history

  18. Fix React 18 ssr test

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    2988d21 View commit details
    Browse the repository at this point in the history

  19. Change .toHaveBeenCalledTimes(0) to .not.toHaveBeenCalled()

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a37665e View commit details
    Browse the repository at this point in the history

  20. Change .toHaveBeenCalledTimes(1) to .toHaveBeenCalledOnce()

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    439030f View commit details
    Browse the repository at this point in the history

  21. Fix duplicate React import in hoistStatics.ts

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f05bf2f View commit details
    Browse the repository at this point in the history

  22. Bump @testing-library/dom to version 10.4.0

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    5acc575 View commit details
    Browse the repository at this point in the history

  23. Bump @testing-library/jest-dom to version 6.6.3

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e0701ac View commit details
    Browse the repository at this point in the history

  24. Bump jsdom to version 25.0.1

    @aryaemami59
    aryaemami59 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f80d281 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Bump @testing-library/react to version 16.0.1

    @aryaemami59
    aryaemami59 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5f46b99 View commit details
    Browse the repository at this point in the history