Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes breaking change for React Native #40

Closed
wants to merge 1 commit into from
Closed

Fixes breaking change for React Native #40

wants to merge 1 commit into from

Conversation

lwansbrough
Copy link

Fixes #39

@gaearon
Copy link
Contributor

gaearon commented Aug 9, 2015

This breaks the web version: ReferenceError: __DEV__ is not defined.
You can run npm test to check.

@gaearon
Copy link
Contributor

gaearon commented Aug 9, 2015

Another problem with this condition is that Uglify won't know what to cut out at the build time because people's Webpack/Browserify configs have no idea what __DEV__ is.

@gaearon
Copy link
Contributor

gaearon commented Aug 9, 2015

For now I think I fixed it with 238e7d9. Will be out in 0.7.0 shortly, I'll deprecate 0.6.0.

@gaearon gaearon closed this Aug 9, 2015
@gaearon
Copy link
Contributor

gaearon commented Aug 9, 2015

Please let me know if 0.7.0 helps.

@lwansbrough
Copy link
Author

Thanks, I'm out right now but I'll give it a shot when I get back. Cheers!

@dsibiski dsibiski mentioned this pull request Aug 10, 2015
Closed
vjeux pushed a commit to vjeux/react-native that referenced this pull request Aug 11, 2015
@dsibiski
Adds process.env.NODE_ENV polyfill
e163df3 
Summary:
There are many libraries that use `NODE_ENV` to check whether the code is running in
"production" mode or not. This allows those library authors to not have to add conditionals
for React Native.

One such library is Redux: reduxjs/react-redux#40

Thanks to @brentvatne for providing the solution via this tweet (via his phone in the airport 😉): https://twitter.com/notbrent/status/630440250951749632

/cc @vjeux @gaearon @zpao @amasad
Closes facebook#2279
Github Author: Dave Sibiski <dsibiski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwansbrough @gaearon