Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite connect() for better performance and extensibility #416

Closed
wants to merge 76 commits into from
Closed

Rewrite connect() for better performance and extensibility #416

wants to merge 76 commits into from

Commits on Jun 16, 2016

  1. Reimplementing connect() and extracting connectToStore() based on 're… 

    …select'. (6 failing tests to go)
    @jimbolla
    jimbolla committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    ee4366b View commit details
    Browse the repository at this point in the history

  2. Changes to fix failing tests (4 fails to go)

    @jimbolla
    jimbolla committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    2aec436 View commit details
    Browse the repository at this point in the history

  3. Change code to make tests for factory mapStateToProps/mapDispatchToPr… 

    …ops pass. BREAKING CHANGE: requires setting an option parameter mapStateIsFactory/mapDispatchIsFactory to signal factory methods.
    @jimbolla
    jimbolla committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    fe7358c View commit details
    Browse the repository at this point in the history

  4. Adjust remaining 2 failing tests to account for slightly different be… 

    …hind-the-scenes behavior of new implementation.
    @jimbolla
    jimbolla committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    9967a18 View commit details
    Browse the repository at this point in the history

  5. add dispatchable to the exported functions

    @jimbolla
    jimbolla committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    a12c1ec View commit details
    Browse the repository at this point in the history

  6. Replace string ref with function ref. Adjust test to match

    @jimbolla
    jimbolla committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    27f613d View commit details
    Browse the repository at this point in the history

  7. Generalized a couple error messages

    @jimbolla
    jimbolla committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    106ded6 View commit details
    Browse the repository at this point in the history

  8. make additional options passed to connect() fall through to connectTo… 

    …Store()
    @jimbolla
    jimbolla committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    cde8ba2 View commit details
    Browse the repository at this point in the history

  9. rename connectToStore to connectAdvanced

    @jimbolla
    jimbolla committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    5a631ab View commit details
    Browse the repository at this point in the history

  10. pull some utility functions out of connectAdvanced into their own uti… 

    …ls files
    @jimbolla
    jimbolla committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    3416b42 View commit details
    Browse the repository at this point in the history

  11. refactor connect + connectAdvanced

    @jimbolla
    jimbolla committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    6786824 View commit details
    Browse the repository at this point in the history

  12. remove dispatchable()... this probably doesn't need to be a part of r… 

    …eact-redux.
    @jimbolla
    jimbolla committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    5e72f23 View commit details
    Browse the repository at this point in the history

  13. remove unneeded selector value on unmount

    @jimbolla
    jimbolla committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    7890b4c View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2016

  1. avoid excess verify() when using defaultMergeProps

    @jimbolla
    jimbolla committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    612562d View commit details
    Browse the repository at this point in the history

  2. pull buildSelector out of connectAdvanced... less function nesting

    @jimbolla
    jimbolla committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    81434df View commit details
    Browse the repository at this point in the history

  3. refactor connect() selector builders

    @jimbolla
    jimbolla committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    71655ad View commit details
    Browse the repository at this point in the history

  4. remove need for explicit factory flags

    @jimbolla
    jimbolla committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    3266aa9 View commit details
    Browse the repository at this point in the history

  5. don't do shape verification in production ENV

    @jimbolla
    jimbolla committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    4dbeeb1 View commit details
    Browse the repository at this point in the history

  6. refactor to split init from trySubscribe

    @jimbolla
    jimbolla committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    74e0e09 View commit details
    Browse the repository at this point in the history

  7. Move subscribe from willMount to didMount to avoid serverside memory … 

    …leaks
    @jimbolla
    jimbolla committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    cd75a22 View commit details
    Browse the repository at this point in the history

  8. Remove extra createShallowEqualSelector file since it's not adding mu… 

    …ch value
    @jimbolla
    jimbolla committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    9de43b2 View commit details
    Browse the repository at this point in the history

  9. move ref/recomputationsProp setters into buildSelector... simplify re… 

    …nder()
    @jimbolla
    jimbolla committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    3e1ddbd View commit details
    Browse the repository at this point in the history

  10. refactor + comment advancedConnect

    @jimbolla
    jimbolla committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    b769209 View commit details
    Browse the repository at this point in the history

  11. pull buildSelector func into own file

    @jimbolla
    jimbolla committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    70395c9 View commit details
    Browse the repository at this point in the history

  12. Make buildSelector injectable into connectAdvanced as another option

    @jimbolla
    jimbolla committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    2ae0c3c View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2016

  1. refactor+comment connect.js

    @jimbolla
    jimbolla committed Jun 18, 2016
    Configuration menu
    Copy the full SHA
    e2e7108 View commit details
    Browse the repository at this point in the history

  2. Change the way nested connected components subscribe so that parent c… 

    …omponents always subscribe before child components, so that parents always update before children.
    @jimbolla
    jimbolla committed Jun 18, 2016
    Configuration menu
    Copy the full SHA
    88e768b View commit details
    Browse the repository at this point in the history

  3. Fix failing tests. Change the way nested components subscribe... inst… 

    …ead of subscribing to the store directly they subscribe via their ancestor connected component. This ensures the ancestor gets to update before its children.
    @jimbolla
    jimbolla committed Jun 18, 2016
    Configuration menu
    Copy the full SHA
    d2b9844 View commit details
    Browse the repository at this point in the history

  4. ensure nested subs are notified properly

    @jimbolla
    jimbolla committed Jun 18, 2016
    Configuration menu
    Copy the full SHA
    859d795 View commit details
    Browse the repository at this point in the history

  5. Eliminate extraneous tracking of recomputations count since we can ju… 

    …st compare last rendered props to new selected props
    @jimbolla
    jimbolla committed Jun 18, 2016
    Configuration menu
    Copy the full SHA
    ce49933 View commit details
    Browse the repository at this point in the history

  6. simplify nested subs code. no need for extra object wrappers

    @jimbolla
    jimbolla committed Jun 18, 2016
    Configuration menu
    Copy the full SHA
    c72bcc0 View commit details
    Browse the repository at this point in the history

  7. rename shouldUseState to dependsOnState to make its meaning more clear

    @jimbolla
    jimbolla committed Jun 18, 2016
    Configuration menu
    Copy the full SHA
    9fef522 View commit details
    Browse the repository at this point in the history

  8. prebind notifyNestedSubs to avoid extra lambda func

    @jimbolla
    jimbolla committed Jun 18, 2016
    Configuration menu
    Copy the full SHA
    ed52f05 View commit details
    Browse the repository at this point in the history

  9. Add WrappedComponent as one of the option params passed to buildSelec… 

    …tor(). Useful if one wanted to build a selector from the component's attributes, such as its propTypes, for example.
    @jimbolla
    jimbolla committed Jun 18, 2016
    Configuration menu
    Copy the full SHA
    39fbe00 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2016

  1. Extract Subscription class from connectAdvanced

    @jimbolla
    jimbolla committed Jun 19, 2016
    Configuration menu
    Copy the full SHA
    1b8fb69 View commit details
    Browse the repository at this point in the history

  2. Replace reselect with manual memoization in buildSelector. Faster!

    @jimbolla
    jimbolla committed Jun 19, 2016
    Configuration menu
    Copy the full SHA
    5f0f85f View commit details
    Browse the repository at this point in the history

  3. refactor buildSelector

    @jimbolla
    jimbolla committed Jun 19, 2016
    Configuration menu
    Copy the full SHA
    03c62ef View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2016

  1. refactor connect()... extract selectors, replace reselect with hand-r… 

    …olled memoization
    @jimbolla
    jimbolla committed Jun 20, 2016
    Configuration menu
    Copy the full SHA
    0906904 View commit details
    Browse the repository at this point in the history

  2. Re-add isSubscribed() to reduce test delta

    @jimbolla
    jimbolla committed Jun 20, 2016
    Configuration menu
    Copy the full SHA
    d4686d8 View commit details
    Browse the repository at this point in the history

  3. refactor buildFactoryAwareSelector and remove extraneous selector ind… 

    …ex file
    @jimbolla
    jimbolla committed Jun 20, 2016
    Configuration menu
    Copy the full SHA
    a45ae23 View commit details
    Browse the repository at this point in the history

  4. improve memoization perf

    @jimbolla
    jimbolla committed Jun 20, 2016
    Configuration menu
    Copy the full SHA
    e51315f View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2016

  1. refactor connect + selectors for clarity

    @jimbolla
    jimbolla committed Jun 21, 2016
    Configuration menu
    Copy the full SHA
    4969368 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2016

  1. refactor connect + selectors

    @jimbolla
    jimbolla committed Jun 23, 2016
    Configuration menu
    Copy the full SHA
    b1cc3d3 View commit details
    Browse the repository at this point in the history

  2. pull apart buildSelector into its pieces and move them into getFinalP… 

    …rops and connectAdvanced because it wasn't clear what it did as it was
    @jimbolla
    jimbolla committed Jun 23, 2016
    Configuration menu
    Copy the full SHA
    78045dc View commit details
    Browse the repository at this point in the history

  3. Move where 'extra props' (ref and recomputations) are added to the fi… 

    …nal props to simplify memoization functions
    @jimbolla
    jimbolla committed Jun 23, 2016
    Configuration menu
    Copy the full SHA
    846c09b View commit details
    Browse the repository at this point in the history

  4. Refactor props memoization

    @jimbolla
    jimbolla committed Jun 23, 2016
    Configuration menu
    Copy the full SHA
    ee77f3f View commit details
    Browse the repository at this point in the history

  5. Move ownProps memoization into connectAdvanced to simplify selectors.

    @jimbolla
    jimbolla committed Jun 23, 2016
    Configuration menu
    Copy the full SHA
    8170f16 View commit details
    Browse the repository at this point in the history

  6. utilize memoizeProps in createFactoryAwareSelector

    @jimbolla
    jimbolla committed Jun 23, 2016
    Configuration menu
    Copy the full SHA
    3287546 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2016

  1. rename recomputations to renderCount to make its intent clearer

    @jimbolla
    jimbolla committed Jun 24, 2016
    Configuration menu
    Copy the full SHA
    0b9fd95 View commit details
    Browse the repository at this point in the history

  2. refactoring selectors + connect for clarity

    @jimbolla
    jimbolla committed Jun 24, 2016
    Configuration menu
    Copy the full SHA
    30857f4 View commit details
    Browse the repository at this point in the history

  3. Hide connectAdvanced and advancedOptions

    @jimbolla
    jimbolla committed Jun 24, 2016
    Configuration menu
    Copy the full SHA
    1e0a66c View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2016

  1. fix nits

    @jimbolla
    jimbolla committed Jun 26, 2016
    Configuration menu
    Copy the full SHA
    5bc7b83 View commit details
    Browse the repository at this point in the history

  2. fix messed up path

    @jimbolla
    jimbolla committed Jun 26, 2016
    Configuration menu
    Copy the full SHA
    1e7f2d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2016

  1. Add guard for the case of a component causing its siblings to unsubsc… 

    …ribe in the middle of the notification loop.
    @jimbolla
    jimbolla committed Jul 2, 2016
    Configuration menu
    Copy the full SHA
    e284d8b View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2016

  1. Add comments to connect.js

    @jimbolla
    jimbolla committed Jul 3, 2016
    Configuration menu
    Copy the full SHA
    395c4ee View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2016

  1. refactoring + some perf opimizations

    @jimbolla
    jimbolla committed Jul 9, 2016
    Configuration menu
    Copy the full SHA
    dab9c85 View commit details
    Browse the repository at this point in the history

  2. refactoring+comments for clarity

    @jimbolla
    jimbolla committed Jul 9, 2016
    Configuration menu
    Copy the full SHA
    cabd376 View commit details
    Browse the repository at this point in the history

  3. refactoring

    @jimbolla
    jimbolla committed Jul 9, 2016
    Configuration menu
    Copy the full SHA
    35d175f View commit details
    Browse the repository at this point in the history

  4. Optimize Subscription subscribe/unsubscribe

    @jimbolla
    jimbolla committed Jul 9, 2016
    Configuration menu
    Copy the full SHA
    67d6e13 View commit details
    Browse the repository at this point in the history

  5. comments

    @jimbolla
    jimbolla committed Jul 9, 2016
    Configuration menu
    Copy the full SHA
    a604856 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2016

  1. refactor selectors

    @jimbolla
    jimbolla committed Jul 10, 2016
    Configuration menu
    Copy the full SHA
    652d85c View commit details
    Browse the repository at this point in the history

  2. rename files

    @jimbolla
    jimbolla committed Jul 10, 2016
    Configuration menu
    Copy the full SHA
    d56c36d View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2016

  1. Change Subscription to follow same subscribe/unsubscribe/notify mecha… 

    …nics as redux's createStore
    @jimbolla
    jimbolla committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    418b659 View commit details
    Browse the repository at this point in the history

  2. refactoring connect's selectors to move logic to determine what to re… 

    …compute into getFinalProps.js
    @jimbolla
    jimbolla committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    44fd92d View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2016

  1. refactoring/optimizing connect+selectors

    @jimbolla
    jimbolla committed Jul 12, 2016
    Configuration menu
    Copy the full SHA
    1cb72c0 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2016

  1. refactoring/optimizing connect+selectors

    @jimbolla
    jimbolla committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    5ec8143 View commit details
    Browse the repository at this point in the history

  2. Merge selectors and connect.js into a connect folder

    @jimbolla
    jimbolla committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    1120555 View commit details
    Browse the repository at this point in the history

  3. comments

    @jimbolla
    jimbolla committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    55b49b2 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2016

  1. refactoring connect

    @jimbolla
    jimbolla committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    86a4bbe View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2016

  1. Optimize connectAdvanced to not create subscription if it shouldn't r… 

    …espond to state changes.
    @jimbolla
    jimbolla committed Jul 16, 2016
    Configuration menu
    Copy the full SHA
    3cc504f View commit details
    Browse the repository at this point in the history

  2. Refactor - put dependsOnOwnProps right on the selector func instead o… 

    …f extra "meta" property
    @jimbolla
    jimbolla committed Jul 16, 2016
    Configuration menu
    Copy the full SHA
    3c5c80e View commit details
    Browse the repository at this point in the history

  3. Add test from #293 and uncomment now-passing expect in 'should pass s… 

    …tate consistently to mapState'
    @jimbolla
    jimbolla committed Jul 16, 2016
    Configuration menu
    Copy the full SHA
    de81801 View commit details
    Browse the repository at this point in the history

  4. Added passing test from #395

    @jimbolla
    jimbolla committed Jul 16, 2016
    Configuration menu
    Copy the full SHA
    e2df051 View commit details
    Browse the repository at this point in the history

  5. Add passing test from #429

    @jimbolla
    jimbolla committed Jul 16, 2016
    Configuration menu
    Copy the full SHA
    e907f85 View commit details
    Browse the repository at this point in the history

  6. Add code + test for #436

    @jimbolla
    jimbolla committed Jul 16, 2016
    Configuration menu
    Copy the full SHA
    a6d82f0 View commit details
    Browse the repository at this point in the history

  7. Extract buildConnectOptions out of connect()... will make testing easier

    @jimbolla
    jimbolla committed Jul 16, 2016
    Configuration menu
    Copy the full SHA
    a4d3211 View commit details
    Browse the repository at this point in the history