-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@reduxjs/toolkit: 1.6.2 → 1.7.0] TS2344: Type 'Definitions[EndpointName]' does not satisfy the constraint 'QueryDefinition<any, any, any, any, string>'. #1833
Comments
Hoooo-ly smoke, that's ugly :) Also looks like the same error as #1829, I think? |
Seems like this is a problem within our sources that TS 4.2 which we use for building doesn't detect - and then somehow it also doesn't trigger in the type tests |
Isn't this a promising candidate for MEME? like |
Should be fixed in https://github.com/reduxjs/redux-toolkit/releases/tag/v1.7.1 . |
@markerikson @phryneas I confirmed this is fixed, thank you for faster fixing! 😄 |
heh, thank @phryneas for actually fixing it - I just merged and released :) |
@markerikson haha, also I'm getting thousand number count of contributions from Github that showing my top page. But approximately 90% are just merging npm automated dependency update PR from Depfu. Honestly increasing number and top page become more green glass is bring me satisfaction, but that's can never say 'contributions'. 😅 |
I ran the
tsc
command immediately after updating reduxjs/toolkit from 1.6.2 to 1.7.0, and encountered this error.There is no way I can read this and understand it, can anyone tell me the cause or give me a clue?
envirionment
TypeScirpt v4.5.4
node: 16.9
github actions container
Reproduction
https://github.com/laststance/react-re-render-rules/runs/4494596354?check_suite_focus=true
The text was updated successfully, but these errors were encountered: