Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Custom arg serialization per endpoint #2491

Closed
michal-kurz opened this issue Jul 6, 2022 · 3 comments
Closed

Feature : Custom arg serialization per endpoint #2491

michal-kurz opened this issue Jul 6, 2022 · 3 comments
Milestone

Comments

@michal-kurz
Copy link
Contributor

michal-kurz commented Jul 6, 2022

I want to be able to provide custom arg serializer per endpoint. @phryneas told me on stackoverflow that a PR with minimal overhead would be welcome. I have a solution, but cannot push into the repo to make a PR:

ERROR: Permission to reduxjs/redux-toolkit.git denied to michal-kurz.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights

Can I please get the needed permissions?
Thank you 🙏

@phryneas
Copy link
Member

phryneas commented Jul 6, 2022

You need to fork the repo, push it into a branch on your own repo and then open a pull request.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

@michal-kurz
Copy link
Contributor Author

michal-kurz commented Jul 6, 2022

@phryneas Alright, I did that!

PR is here: #2493
with some additional questions/info in description

@markerikson markerikson added this to the 1.9 milestone Jul 7, 2022
@markerikson
Copy link
Collaborator

markerikson commented Aug 11, 2022

Just merged #2493 , so I'm going to close this. Thanks!

If you want to try it out now, please install the preview build from the 1.9 integration branch at #2401 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants