Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypedUseMutationTrigger should not contain the word "Use" #4203

Closed
tylerlaprade opened this issue Feb 14, 2024 · 2 comments · Fixed by #4204
Closed

TypedUseMutationTrigger should not contain the word "Use" #4203

tylerlaprade opened this issue Feb 14, 2024 · 2 comments · Fixed by #4204

Comments

@tylerlaprade
Copy link

TypedUseMutationTrigger is a helpful wrapper for MutationTrigger (thanks for adding it by the way! It resolved an issue I was facing). However, the name is inconsistent. TypedUseMutation is a wrapper for UseMutation. The extra Use breaks the parallel naming structure.
@EskiMojo14 EskiMojo14 mentioned this issue Feb 14, 2024
Merged
@EskiMojo14
Copy link
Collaborator

EskiMojo14 commented Feb 14, 2024 •
edited
Loading

huh, good spot - that's annoying, as renaming it is technically a breaking change. in the linked PR i've currently included a deprecated alias to indicate the change, but considering it's only been available for 2 days I'm tempted to just forgo that as i imagine the number of users affected will be very small

edit: just hard renaming it, counting it as a bug fix

@EskiMojo14
Copy link
Collaborator

released in 2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tylerlaprade @EskiMojo14