Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createAsyncThunk: support for meta #1083

Merged
merged 9 commits into from
May 31, 2021
Merged

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented May 23, 2021

Gotta add docs & more type tests for different scenarios on this one, but this would essentially be it.

This should close #750, #924, #1044

@markerikson can you take a look if this covers all your thoughts?

@phryneas
Copy link
Member Author

Damn, that failed fast 😅

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 23, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5500116:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration

@github-actions
Copy link

github-actions bot commented May 23, 2021

Size Change: +1 kB (0%)

Total Size: 531 kB

Filename Size Change
dist/query/react/rtk-query-react.umd.js 187 kB +91 B (0%)
dist/query/react/rtk-query-react.umd.min.js 62.8 kB +59 B (0%)
dist/query/rtk-query.umd.js 27.1 kB +81 B (0%)
dist/query/rtk-query.umd.min.js 16.1 kB +63 B (0%)
dist/redux-toolkit.cjs.development.js 12.1 kB +101 B (+1%)
dist/redux-toolkit.cjs.production.min.js 5.87 kB +68 B (+1%)
dist/redux-toolkit.esm.js 11.7 kB +110 B (+1%)
dist/redux-toolkit.modern.development.js 9.6 kB +97 B (+1%)
dist/redux-toolkit.modern.js 9.63 kB +96 B (+1%)
dist/redux-toolkit.modern.production.min.js 4.58 kB +70 B (+2%)
dist/redux-toolkit.umd.js 22 kB +102 B (0%)
dist/redux-toolkit.umd.min.js 10.8 kB +64 B (+1%)
ℹ️ View Unchanged
Filename Size Change
dist/index.js 146 B 0 B
dist/query/index.js 144 B 0 B
dist/query/react/index.js 149 B 0 B
dist/query/react/rtk-query-react.cjs.development.js 17.3 kB 0 B
dist/query/react/rtk-query-react.cjs.production.min.js 11.1 kB 0 B
dist/query/react/rtk-query-react.esm.js 16.9 kB 0 B
dist/query/react/rtk-query-react.modern.development.js 13.9 kB 0 B
dist/query/react/rtk-query-react.modern.js 14 kB 0 B
dist/query/react/rtk-query-react.modern.production.min.js 9.25 kB 0 B
dist/query/rtk-query.cjs.development.js 14.5 kB 0 B
dist/query/rtk-query.cjs.production.min.js 9.34 kB 0 B
dist/query/rtk-query.esm.js 14.2 kB 0 B
dist/query/rtk-query.modern.development.js 11.6 kB 0 B
dist/query/rtk-query.modern.js 11.7 kB 0 B
dist/query/rtk-query.modern.production.min.js 7.69 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented May 23, 2021

✔️ Deploy Preview for redux-starter-kit-docs ready!

🔨 Explore the source changes: 5500116

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/60b548c0ac2d76000816a1b7

😎 Browse the preview: https://deploy-preview-1083--redux-starter-kit-docs.netlify.app

@phryneas phryneas mentioned this pull request May 23, 2021
@github-actions
Copy link

github-actions bot commented May 27, 2021

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit (cjs.production.min.js) 12.16 KB (+0.46% 🔺)
1. entry point: @reduxjs/toolkit (esm.js) 10.19 KB (+0.68% 🔺)
1. entry point: @reduxjs/toolkit/query (cjs.production.min.js) 20.06 KB (+0.3% 🔺)
1. entry point: @reduxjs/toolkit/query (esm.js) 17.08 KB (+0.31% 🔺)
1. entry point: @reduxjs/toolkit/query/react (cjs.production.min.js) 21.83 KB (+0.28% 🔺)
1. entry point: @reduxjs/toolkit/query/react (esm.js) 19.42 KB (+0.3% 🔺)
2. entry point: @reduxjs/toolkit (without dependencies) (cjs.production.min.js) 5.51 KB (+1.26% 🔺)
2. entry point: @reduxjs/toolkit (without dependencies) (esm.js) 5.48 KB (+1.3% 🔺)
2. entry point: @reduxjs/toolkit/query (without dependencies) (cjs.production.min.js) 8.95 KB (0%)
2. entry point: @reduxjs/toolkit/query (without dependencies) (esm.js) 9.34 KB (0%)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (cjs.production.min.js) 2.25 KB (0%)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (esm.js) 2.1 KB (0%)
3. createSlice (esm.js) 5.15 KB (0%)
3. createEntityAdapter (esm.js) 5.19 KB (0%)
3. configureStore (esm.js) 5.2 KB (0%)
3. createApi (esm.js) 15.7 KB (+0.35% 🔺)
3. createApi (react) (esm.js) 17.98 KB (+0.32% 🔺)
3. fetchBaseQuery (esm.js) 10.61 KB (+0.5% 🔺)
3. setupListeners (esm.js) 9.76 KB (+0.57% 🔺)
3. ApiProvider (esm.js) 16.96 KB (+0.33% 🔺)

@phryneas
Copy link
Member Author

Added a bunch of docs for now, we can always add more later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant