Add extra to BaseQueryApi #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for redux-starter-kit-docs ready! 🔨 Explore the source changes: f73e4bc 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6109b462daa65900083c2bb8 😎 Browse the preview: https://deploy-preview-1378--redux-starter-kit-docs.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f73e4bc:
|
|
Looks good so far. Could you please also add a test that shows passing |
ricksanchez
force-pushed
the
fix/add-missing-extra-query-api
branch
from
fa4ebb1
to
f73e4bc
Compare
|
Done, there was also style issues that were not detected by the build. |
phryneas
approved these changes
Aug 3, 2021
msutkowski
approved these changes
Aug 4, 2021
|
What else is required in order to merge? |
|
Me not forgetting to press the "merge" button ^^ Thanks for the PR! |
bors bot
referenced
this pull request
in ttbud/ttbud
Oct 6, 2021
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@reduxjs/toolkit](https://redux-toolkit.js.org) ([source](https://github.com/reduxjs/redux-toolkit)) | [`1.6.1` -> `1.6.2`](https://renovatebot.com/diffs/npm/@reduxjs%2ftoolkit/1.6.1/1.6.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>reduxjs/redux-toolkit</summary> ### [`v1.6.2`](https://github.com/reduxjs/redux-toolkit/releases/v1.6.2) [Compare Source](https://github.com/reduxjs/redux-toolkit/compare/v1.6.1...v1.6.2) This release fixes several small issues with RTK Query, as well as a regression in the `createAsyncThunk` types and an issue with sourcemap URLs. #### Changelog ##### RTK Query Fixes The `isLoading` flag should only ever be `true` on the first run of a hook, but would sometimes briefly flip to `true` on later calls. That should now stay the correct value. `fetchBaseQuery` should now work properly when used in conjunction with `node-fetch`. The `BaseQueryApi` object now correctly includes the `extra` argument that was provided when configuring the thunk middleware, if any. ##### Other Fixes Sourcemap URLs should now be correct, especially for the CommonJS build artifacts. `createAsyncThunk`'s types have been updated to correctly infer return values when working with enums. Lots of assorted docs tweaks and updates! #### What's Changed - Add extra to BaseQueryApi by [@​ricksanchez](https://github.com/ricksanchez) in [https://github.com/reduxjs/redux-toolkit/pull/1378](https://github.com/reduxjs/redux-toolkit/pull/1378) - fix: point sourceMappingURL to correct sourcemaps in build artifacts by [@​jawadsh123](https://github.com/jawadsh123) in [https://github.com/reduxjs/redux-toolkit/pull/1459](https://github.com/reduxjs/redux-toolkit/pull/1459) - fix: `createAsyncThunk` union return values fall back to allowing only single member by [@​phryneas](https://github.com/phryneas) in [https://github.com/reduxjs/redux-toolkit/pull/1449](https://github.com/reduxjs/redux-toolkit/pull/1449) - fix `fetchBaseQuery` for usage with `node-fetch` by [@​phryneas](https://github.com/phryneas) in [https://github.com/reduxjs/redux-toolkit/pull/1473](https://github.com/reduxjs/redux-toolkit/pull/1473) - fix "isLoading briefly flips back to `true`" [#​1519](https://github.com/reduxjs/redux-toolkit/issues/1519) by [@​phryneas](https://github.com/phryneas) in [https://github.com/reduxjs/redux-toolkit/pull/1520](https://github.com/reduxjs/redux-toolkit/pull/1520) **Full Changelog**: reduxjs/redux-toolkit@v1.6.1...v1.6.2 </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/ttbud/ttbud).
bors bot
referenced
this pull request
in ttbud/ttbud
Oct 6, 2021
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@reduxjs/toolkit](https://redux-toolkit.js.org) ([source](https://github.com/reduxjs/redux-toolkit)) | [`1.6.1` -> `1.6.2`](https://renovatebot.com/diffs/npm/@reduxjs%2ftoolkit/1.6.1/1.6.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>reduxjs/redux-toolkit</summary> ### [`v1.6.2`](https://github.com/reduxjs/redux-toolkit/releases/v1.6.2) [Compare Source](https://github.com/reduxjs/redux-toolkit/compare/v1.6.1...v1.6.2) This release fixes several small issues with RTK Query, as well as a regression in the `createAsyncThunk` types and an issue with sourcemap URLs. #### Changelog ##### RTK Query Fixes The `isLoading` flag should only ever be `true` on the first run of a hook, but would sometimes briefly flip to `true` on later calls. That should now stay the correct value. `fetchBaseQuery` should now work properly when used in conjunction with `node-fetch`. The `BaseQueryApi` object now correctly includes the `extra` argument that was provided when configuring the thunk middleware, if any. ##### Other Fixes Sourcemap URLs should now be correct, especially for the CommonJS build artifacts. `createAsyncThunk`'s types have been updated to correctly infer return values when working with enums. Lots of assorted docs tweaks and updates! #### What's Changed - Add extra to BaseQueryApi by [@​ricksanchez](https://github.com/ricksanchez) in [https://github.com/reduxjs/redux-toolkit/pull/1378](https://github.com/reduxjs/redux-toolkit/pull/1378) - fix: point sourceMappingURL to correct sourcemaps in build artifacts by [@​jawadsh123](https://github.com/jawadsh123) in [https://github.com/reduxjs/redux-toolkit/pull/1459](https://github.com/reduxjs/redux-toolkit/pull/1459) - fix: `createAsyncThunk` union return values fall back to allowing only single member by [@​phryneas](https://github.com/phryneas) in [https://github.com/reduxjs/redux-toolkit/pull/1449](https://github.com/reduxjs/redux-toolkit/pull/1449) - fix `fetchBaseQuery` for usage with `node-fetch` by [@​phryneas](https://github.com/phryneas) in [https://github.com/reduxjs/redux-toolkit/pull/1473](https://github.com/reduxjs/redux-toolkit/pull/1473) - fix "isLoading briefly flips back to `true`" [#​1519](https://github.com/reduxjs/redux-toolkit/issues/1519) by [@​phryneas](https://github.com/phryneas) in [https://github.com/reduxjs/redux-toolkit/pull/1520](https://github.com/reduxjs/redux-toolkit/pull/1520) **Full Changelog**: reduxjs/redux-toolkit@v1.6.1...v1.6.2 </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/ttbud/ttbud).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1377
extra prop added to BaseQueryApi