Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use useSerializedStableValue for value comparison #1533

Merged
merged 4 commits into from
Oct 1, 2021

Conversation

phryneas
Copy link
Member

as a possible solution for #1531, #1526 and others.

@Shrugsy @msutkowski your opinions please

@netlify
Copy link

netlify bot commented Sep 20, 2021

✔️ Deploy Preview for redux-starter-kit-docs ready!

🔨 Explore the source changes: 63fe01d

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/614a410bcb81270007a2ad28

😎 Browse the preview: https://deploy-preview-1533--redux-starter-kit-docs.netlify.app

@github-actions
Copy link

github-actions bot commented Sep 20, 2021

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit (cjs.production.min.js) 12.23 KB (0%)
1. entry point: @reduxjs/toolkit (esm.js) 10.22 KB (0%)
1. entry point: @reduxjs/toolkit/query (cjs.production.min.js) 20.34 KB (0%)
1. entry point: @reduxjs/toolkit/query (esm.js) 17.37 KB (0%)
1. entry point: @reduxjs/toolkit/query/react (cjs.production.min.js) 22.34 KB (+0.6% 🔺)
1. entry point: @reduxjs/toolkit/query/react (esm.js) 19.93 KB (+0.56% 🔺)
2. entry point: @reduxjs/toolkit (without dependencies) (cjs.production.min.js) 5.55 KB (0%)
2. entry point: @reduxjs/toolkit (without dependencies) (esm.js) 5.53 KB (0%)
2. entry point: @reduxjs/toolkit/query (without dependencies) (cjs.production.min.js) 9.2 KB (0%)
2. entry point: @reduxjs/toolkit/query (without dependencies) (esm.js) 9.58 KB (0%)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (cjs.production.min.js) 2.52 KB (+6.53% 🔺)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (esm.js) 2.35 KB (+6.6% 🔺)
3. createSlice (esm.js) 5.16 KB (0%)
3. createEntityAdapter (esm.js) 5.83 KB (0%)
3. configureStore (esm.js) 5.83 KB (0%)
3. createApi (esm.js) 15.66 KB (0%)
3. createApi (react) (esm.js) 18.16 KB (+0.65% 🔺)
3. fetchBaseQuery (esm.js) 10.93 KB (0%)
3. setupListeners (esm.js) 9.8 KB (0%)
3. ApiProvider (esm.js) 17.07 KB (+0.5% 🔺)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 63fe01d:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration

@Shrugsy
Copy link
Collaborator

Shrugsy commented Sep 21, 2021

for posterity, here is a CSB demo showing it happily mounting an error query with deep nested args and no infinite loop:

https://codesandbox.io/s/examples-query-react-basic-with-nested-arg-error-forked-zofoo?file=/src/App.tsx

Copy link
Collaborator

@Shrugsy Shrugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests are updated, LGTM!

Copy link
Member

@msutkowski msutkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works good. Another 🏆 for @phryneas!

@phryneas phryneas added this to the 1.7 milestone Sep 23, 2021
@phryneas phryneas changed the base branch from master to v1.7.0-integration October 1, 2021 08:22
@phryneas phryneas merged commit a44511e into v1.7.0-integration Oct 1, 2021
@phryneas phryneas deleted the pr/useSerializedStableValue branch October 1, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants