-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use useSerializedStableValue
for value comparison
#1533
Conversation
✔️ Deploy Preview for redux-starter-kit-docs ready! 🔨 Explore the source changes: 63fe01d 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/614a410bcb81270007a2ad28 😎 Browse the preview: https://deploy-preview-1533--redux-starter-kit-docs.netlify.app |
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 63fe01d:
|
for posterity, here is a CSB demo showing it happily mounting an error query with deep nested args and no infinite loop: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once tests are updated, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, works good. Another 🏆 for @phryneas!
as a possible solution for #1531, #1526 and others.
@Shrugsy @msutkowski your opinions please