fetchBaseQuery: return nullon empty body for JSON. Add DevWarnings.
#1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 50cf1ef:
|
phryneas
changed the title
queryFn returns a wrong shapenull instead of undefined on empty body for JSON. add dev errors if baseQuery/queryFn returns a wrong shape
phryneas
commented
Nov 12, 2021
| @@ -54,7 +54,7 @@ const handleResponse = async ( | |||
|
|
|||
| if (responseHandler === 'json') { | |||
| const text = await response.text() | |||
| return text.length ? JSON.parse(text) : undefined | |||
| return text.length ? JSON.parse(text) : null | |||
There was a problem hiding this comment.
Note that this is a almost-breaking change, but a very minor one.
It is necessary as we cannot serialize undefined when transferring data from server to client in SSR scenarios.
phryneas
changed the title
null instead of undefined on empty body for JSON. add dev errors if baseQuery/queryFn returns a wrong shapenullon empty body for JSON. Add DevWarnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just something I wanted to do for a while.