Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize serializable check conditions #2000

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

msutkowski
Copy link
Member

@msutkowski msutkowski commented Feb 5, 2022

Fixes #1996

  • state and action checks behave independently, allowing a user to ignoreState and still check actions, or ignoreActions and continue to check state

@msutkowski msutkowski marked this pull request as ready for review February 5, 2022 05:09
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 5, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0dea2e7:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration

@netlify
Copy link

netlify bot commented Feb 5, 2022

✔️ Deploy Preview for redux-starter-kit-docs ready!

🔨 Explore the source changes: 0dea2e7

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/61fe060a74815b0007b65899

😎 Browse the preview: https://deploy-preview-2000--redux-starter-kit-docs.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 5, 2022

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit (cjs.production.min.js) 12.93 KB (0%)
1. entry point: @reduxjs/toolkit (esm.js) 10.79 KB (0%)
1. entry point: @reduxjs/toolkit/query (cjs.production.min.js) 22.67 KB (0%)
1. entry point: @reduxjs/toolkit/query (esm.js) 19.04 KB (0%)
1. entry point: @reduxjs/toolkit/query/react (cjs.production.min.js) 24.91 KB (0%)
1. entry point: @reduxjs/toolkit/query/react (esm.js) 21.73 KB (0%)
2. entry point: @reduxjs/toolkit (without dependencies) (cjs.production.min.js) 5.71 KB (0%)
2. entry point: @reduxjs/toolkit (without dependencies) (esm.js) 5.67 KB (0%)
2. entry point: @reduxjs/toolkit/query (without dependencies) (cjs.production.min.js) 10.12 KB (0%)
2. entry point: @reduxjs/toolkit/query (without dependencies) (esm.js) 10.55 KB (0%)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (cjs.production.min.js) 2.8 KB (0%)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (esm.js) 3.21 KB (0%)
3. createSlice (esm.js) 5.03 KB (0%)
3. createEntityAdapter (esm.js) 6.28 KB (0%)
3. configureStore (esm.js) 5.65 KB (0%)
3. createApi (esm.js) 17.24 KB (0%)
3. createApi (react) (esm.js) 19.95 KB (0%)
3. fetchBaseQuery (esm.js) 11.63 KB (0%)
3. setupListeners (esm.js) 10.42 KB (0%)
3. ApiProvider (esm.js) 18.58 KB (0%)

@msutkowski msutkowski linked an issue Feb 5, 2022 that may be closed by this pull request
@msutkowski msutkowski requested review from markerikson and phryneas and removed request for markerikson February 15, 2022 16:52
@markerikson
Copy link
Collaborator

I can't say I'm thrilled about all the !ignoreActions checks :) But they were there already, I think.

OK, let's go with it.

@markerikson markerikson merged commit eff7527 into master Feb 16, 2022
@markerikson markerikson deleted the fix-serializableCheck branch February 16, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why ignoreActions and ignoredActions overrides ignoreState?
2 participants