Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary condition #846

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Remove unnecessary condition #846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/createSlice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,7 @@ export function createSlice<
actionMatchers = [],
defaultCaseReducer = undefined
] =
typeof options.extraReducers === 'undefined'
? []
: typeof options.extraReducers === 'function'
typeof options.extraReducers === 'function'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If options.extraReducers === undefined, then the result would be [undefined], right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little "wrap-your-head-around" with this.

for options.extraReducers === undefined, this would result in

 const [ 
   extraReducers = {}, 
   actionMatchers = [], 
   defaultCaseReducer = undefined 
 ] = [undefined]

which would then take on the default value of extraReducers = {} at desctructuring.

So yeah, I believe the PR is correct, but I'd like a second opinion here @markerikson or @msutkowski

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with it.

? executeReducerBuilderCallback(options.extraReducers)
: [options.extraReducers]

Expand Down