-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find better decorator names #20
Comments
Provider / Container? |
If the issue is it looking weird in the import { root as reduxRoot } from 'redux';
|
Let's rename Deal? |
I like naming my decorators as verbs, similarly to what you did with |
Yeah.. I like verb decorators. But then I want them to map 1:1 to the components. And components as verbs seem bizarre. |
While I agree on keeping noun for components, I think it is acceptable to Florent Cailhol |
More bikeshedding:
Anything that you like? |
I really like |
I second @ooflorent on this one. Inject seems to describe more what's happening under the hood than control is. |
What about |
Out in 0.7.0. |
I liked previous decorator. While
container
is acceptable,root
is too broad.Maybe you (@gaearon) could rename
root
toprovides
or something similar.Any thoughts?
The text was updated successfully, but these errors were encountered: