-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs Rewrite] Meta-Issue: Overview #3592
Comments
Not sure if it's better suited for this thread or #3593, but @dai-shi has put together a Remark plugin for Docusaurus v2 that lets you write snippets in TS, and automatically have a tabbed code block added with that snippet in both TS and plain JS: https://twitter.com/dai_shi/status/1197816235058069504 We could maybe even take that further and have it do TS, ES6, and ES5. |
Hi guys, I would be glad to help with this issue. I'll read through it tomorrow. |
@markerikson do you think testing should be at the top level of the docs or be a subsection of one of the entries you suggested above? Edit: I see that it would probably go under Recipes (#3596). I wonder if that's where the average developer would go first when looking for that. |
It's under "Recipes" now. I'm inclined to move it under "Real World Usage" somewhere. |
@hbarcelos: for reference:
|
Some feedback from a random HN user ( https://news.ycombinator.com/item?id=21927109 and https://news.ycombinator.com/item?id=21927800 ):
Key point:
I think this matches up with my desire for a "quick start" page that teaches RTK and React-Redux right away. |
As someone who started learning Redux quite late comparing with the time I've known React, I tend to agree. There's too many "intro to redux" tutorials out there. Not many of them are high quality. When you're starting, it's quite hard to separate the husk from the grain. To me, the biggest issue is that common pattern of having different files for action types, action creators and reducers. This adds too much cognitive overhead. Ducks and RTK sort of fix this problem though. It would be nice to have an authoritative piece built along side the community. |
Unfortunately, there's nothing we can do about the mass of existing tutorials out there that are often of poor quality. All we can do is improve the docs, and even then, many times people do not even read the docs - they'd rather search for some tutorial on Medium or watch a course on Udemy. |
Surely we can't force users to read the docs, but what we could possibly do is to help those who actually do that and have that self-contained intro you were talking about and furthermore having some quite thorough "Anti-Patterns" section with a compilation of those poor quality examples (no linking needed I guess) and the implications of using them in a real-world scenario for an extended period of time. I guess the later is easier said than done, but we all have some unwritten rules we like to follow when working in complex apps. Maybe it's time trying to write them down. |
Like the Redux Style Guide? ;) Guess we'll gonna have that placed more prominently. |
RSG does great on the "what I should do" part. If made easier to find, it would be good. However, I think it falls short on the "what I should NOT do" question. I believe the main problem here is that most of the problems from anti-patterns in Redux are not so apparent immediately. It takes you a couple of weeks to realize you screwed up and now you have to make a relatively big refactor in your code base. The hard part of writing a guide for that is that most of the problems are highly dependent on context. I think I started writing something about those cases when I made huge mistakes one or two times, but ended up giving up because actually explaining the problem would be too specific for the application I had at that time. TBH, I haven't worked with Redux on enough complex applications to actually be able to extract those problematic issues from their context and state it as a general problem. Not sure if this can be done, but it would be quite nice to have. |
Asked a series of questions on Twitter about why people avoid docs in the first place, and what sort of landing page / "getting started" info would be most useful: |
Some feedback on the docs layout being hard to follow and making unstated assumptions: https://twitter.com/jaflebol/status/1214562932660391939 And on the flip side, me asking about what techniques make docs good and easier to follow: |
Some notes from @alexkrolick on how the Redux Toolkit docs docs aren't well integrated into the Redux core docs, and how the RTK docs themselves may not be easy to navigate: https://gist.github.com/alexkrolick/c2de33bc00318c8f02eb419975b369ba |
Suggestion to have the Redux docs mention that "spreading out state mutation is a bad idea": |
I'd forgotten that I generally liked how "Redux in Action" describes things. The intro is here: |
Hi - would love to help out on the docs rewrite. I thought the tutorials might be a good place to start, but it seems like lots of people have to put their hand up to help but at the same time we haven't really nailed down how we're going to approach the rewrite of that. Let me know if there's a specific task I could get started with! |
Yeah, per my comments over on the dev.to article, I'm trying to work on the tutorials myself atm (new "Quick Start" first, then rewriting the existing tutorials). One option would be to start updating some existing content, or shuffling it around to new locations. For example, the FAQ pages need to be updated to point to the relevant "Style Guide" entries, and also actually try to match the Style Guide recommendations. Meanwhile, the "Immutable.js" page needs to go away because we now actively recommend against using it, some of the pages under "Recipes" ought to get reorganized into a new "Real-World Usage" section, etc. I'd say start by looking at #3596, #3597, and #3598 , and pick something out of those lists. Let me know if you have any questions on what I'm picturing being doing for those. |
What a great initiative. :) |
I hope this is the right place for my report. |
That link you quoted is broken but the link on the page seems to be working now. The broken version might be cached for you. Have you tried reloading? |
Hmm. @ExpandingShapes , appreciate the notice, but the link does look to be correct. It doesn't point to anything with a |
@markerikson Oh, I forgot to put the link to the article. Just in case, |
Uh... that's weird. I see it both with and without the I dunno. It's one link in the Markdown, which I know is correct. |
This is the parent tracking issue for all the work we'd like to do, and primarily serves to link to the other issues.
I'm initially basing this off my suggested outline for the new docs structure and content. This is absolutely not final, and I expect us to iterate on this a lot as we work through everything.
For now, I'm organizing the top-level task list by category / docs structure section.
Tasks
Planning / Discussion Topics
Notes
Any pages that are moved around must update our Netlify
redirects
file so that visitors see the new page.Questions for Discussion
docs-rewrite
integration branch, or should we just go ahead and updatemaster
piecemeal as we go so that we get the initial benefits? I'm inclined to put changes intomaster
as soon as we're happy with them.The text was updated successfully, but these errors were encountered: