Modify test case ID generation for reducer changing #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,10 +1,16 @@ | |||
| import { ADD_TODO } from './actionTypes'; | |||
|
|
|||
|
|
|||
| var id = (state = []) => | |||
There was a problem hiding this comment.
Let's change this to be function nextId(state = []).
Also please run npm run lint to fix the errors.
Thanks!
There was a problem hiding this comment.
but the I have to write all of return ;)
iamdustan
force-pushed
the
breaking-changes-test-id-incrementer
branch
from
4c3101c
to
667d8f5
Compare
gaearon
added a commit
that referenced
this pull request
Jul 1, 2015
…menter Modify test case ID generation for reducer changing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was reading through the test cases in the #195 it caught me off guard that the IDs were being reused. This modifies the test case to not reuse IDs so you can follow the flow of where the reducer is swapped with where the next ID appears rather than only the task text string.