Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth] createMiddlewareAuth (web side) for dbAuth #10445

Closed
dac09 opened this issue Apr 11, 2024 · 0 comments · Fixed by #10444
Closed

[Auth] createMiddlewareAuth (web side) for dbAuth #10445

dac09 opened this issue Apr 11, 2024 · 0 comments · Fixed by #10444
Assignees
@dthyresson @dac09

Comments

@dac09
Copy link
Collaborator

dac09 commented Apr 11, 2024 •
edited
Loading

Implement web client for dbAuth (so auth speaks to middleware and not to graphql)

We are also going to document changes to templates on user's projects.
@dac09 dac09 mentioned this issue Apr 11, 2024
Merged
1 task
dthyresson pushed a commit that referenced this issue Apr 15, 2024
@dac09
feat(server-auth): Part 1/3: dbAuth middleware support (web side chan…
a6b6136 
…ges) (#10444)

Closes #10445

**Part 1/3: dbAuth middleware support**
~1. Updates dbAuthHandler to handle POST requests for login, logout,
signup via the middleware~
taking this out of this PR, and going to PR separately. 
2. Updates the dbAuth web client to speak to middleware instead of
graphql
3. Implements fetching current user from middleware

**What it does not have:**
- actual middleware
- when SSR/RSC is enabled AND you're logged in, graphql requests will
fail with 500, because auth context hasn't been updated yet to support
cookies
(https://github.com/orgs/redwoodjs/projects/18/views/1?query=is%3Aopen+sort%3Aupdated-desc&pane=issue&itemId=59446357)

**Before merging this:** 
- [x] Validate graphql auth is not broken
~- [ ] Validate webAuthN + graphql is not broken~
~-[ ] Merge dbAuthHandler and tests again!~
Moved to separate PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dthyresson dthyresson

@dac09 dac09

Labels
None yet
Projects
Bighorn Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(server-auth): Part 1/3: dbAuth middleware support (web side changes) redwoodjs/redwood
2 participants
@dthyresson @dac09