fix(deps): update React to latest canary 19.x #10482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
added
release:breaking
This was referenced Apr 20, 2024
Tobbe
added a commit
to Tobbe/redwood
that referenced
this pull request
Apr 22, 2024
This reverts commit 1ed2650.
Tobbe
added a commit
that referenced
this pull request
Apr 22, 2024
dac09
added a commit
that referenced
this pull request
Apr 22, 2024
…g-gen-mw-p2 * 'main' of github.com:redwoodjs/redwood: fix(deps): update React to latest canary 19.x (#10496) fix(upgrade): Download yarn patches (#10497) Revert React 19 upgrade (#10482 and #10491) (#10495) Modified type for describeScenario (#10468) fix(upgrade): Download yarn patches (#10491) fix(deps): update React to latest canary 19.x (#10482) chore(dataMigrate): Fix package.json directory value (#10490) RSC: css preinit: Add required option precedence (#10481) chore(renovate): Remove config for unused package (#10489) RSC: Update test projects to use new @apollo/client-react-streaming (#10488) RSC: Remove unused vite patch from test-project-rsa (#10487) chore(ssr): Switch to use `@apollo/client-react-streaming` package (#10484) chore(docs): Move .mdx import into separate file (#10486) fix(cli): avoid `npx` during upgrade command (#10479) fix: Fixes Unknown Fragment issues due to GraphQL Tag type mismatch in web (#10357) RSC: Clean up some comments and logs (#10480) feat: redwoodjs/auth-dbauth-middleware - Part 2/3 - Auth Middleware for dbAuth to authenticate users via cookie (#10447)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates react and react-dom to the latest canary release.
We're going from 18.3.x canaries to 19.x canaries here. So technically a breaking change because of the major version upgrade. But from what I've been able to find there are no breaking changes detailed by the React team. Plus we don't ship RW with this (yet). We still ship with the latest stable release of React. So for RW I'm not exactly sure how to label this, but going with "fix" for now. And the reason for that is that we need this update to fix a bug with
preinitpresent in the older version of React that we're currently on.React 19 is very new, so a couple of our dependencies aren't updated to support it yet. Notably I had to patch both
@apollo/clientand@storybook/react-dom-shim. Patching and setting resolutions is something we really don't want to do. Definitely need to revert those changes before we can release this.PR to support React 19 in Apollo: apollographql/apollo-client#11795
PR to support React 19 in Storybook: storybookjs/storybook#26898
When those PRs get merged we should come back and remove our patches and resolutions