From f9b46769e2e11ebb5c02a7a4fc6a36eb495785ee Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 6 Dec 2018 22:38:50 -0800 Subject: [PATCH] doc: update "Testing and CI" in Collaborator Guide MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Update "Testing and CI" in the Collaborator Guide. Remove redundant material. Shorten sentences. Remove incorrect material. (Specifically, we don't require test cases to be included in all pull requests that modify exectuable code. For example, if code is refactored, then passing existing tests is sufficient.) PR-URL: https://github.com/nodejs/node/pull/24884 Reviewed-By: Daniel Bevenius Reviewed-By: Richard Lau Reviewed-By: Michaël Zasso Reviewed-By: Vse Mozhet Byt Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Anto Aravinth Reviewed-By: Trivikram Kamat --- COLLABORATOR_GUIDE.md | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 48915c4fc4085a..2bce29e5645e9b 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -174,20 +174,17 @@ the comment anyway to avoid any doubt. ### Testing and CI -All bugfixes require a test case which demonstrates the defect. The -test should *fail* before the change, and *pass* after the change. - -All pull requests that modify executable code should also include a test case -and must be subjected to continuous integration tests on the -[project CI server](https://ci.nodejs.org/). The pull request should have a CI -status indicator. - -Do not land any Pull Requests without passing (green or yellow) CI runs. If you -believe any failed (red or grey) CI sub-tasks are unrelated to the change in the -Pull Request, use "Resume Build" in the left navigation of the relevant -`node-test-pull-request` job. It will create a new `node-test-pull-request` run -that preserves all the green results from the current job but re-runs everything -else. +All fixes must have a test case which demonstrates the defect. The test should +fail before the change, and pass after the change. + +All pull requests must pass continuous integration tests on the +[project CI server](https://ci.nodejs.org/). + +Do not land any Pull Requests without passing (green or yellow) CI runs. If +there are CI failures unrelated to the change in the Pull Request, try "Resume +Build". It is in the left navigation of the relevant `node-test-pull-request` +job. It will preserve all the green results from the current job but re-run +everything else. #### Useful CI Jobs