Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile breakpoint css updates and related miscellaneous #49

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Oct 19, 2024

Description

This PR makes mobile breakpoint css updates and related miscellaneous

PR #47 must land first

GitHub Issue: Resolves #48

Changes

  • Add Refactor RGB logo as the favicon for the site
  • Add a large max width to the page and all components on the coaching session page (1536px)
  • Always show the DashboardContainer component for all media breakpoints
  • Update mobile-nav and command-menu items to non-template links
  • Make sure the login form always shows at all breakpoints and tweak the top padding for the small breakpoint

Screenshots / Videos Showing UI Changes (if applicable)

  • Minor multiple tweaks, no screenshot supplied

Testing Strategy

  1. Notice that the favicon in your browser tab is now an RGB Refactor logo
  2. Resize the login and dashboard pages and notice the main content remains and is a responsive layout design
  3. Resize the dashboard or coaching session page and notice the mobile menu appear
  4. The menu should only have three choices, Dashboard, Profile and Log out

Concerns

  • Log out from the mobile-nav doesn't work yet. We'll need a more universal logout method to call that isn't just a part of user-nav alone.

@jhodapp jhodapp added enhancement Improves existing functionality or feature bug fix Fixes a specific Issue labels Oct 19, 2024
@jhodapp jhodapp added this to the 1.0-rc1 milestone Oct 19, 2024
@jhodapp jhodapp self-assigned this Oct 19, 2024
@jhodapp jhodapp marked this pull request as ready for review October 19, 2024 20:36
@jhodapp jhodapp merged commit a1d2f69 into main Oct 23, 2024
1 check passed
@jhodapp jhodapp deleted the 48-mobile-breakpoint-css-updates branch October 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixes a specific Issue enhancement Improves existing functionality or feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Mobile breakpoint CSS updates
2 participants