Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode style for TipTap component toolbar buttons #50

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Nov 1, 2024

Description

This PR fixes dark mode styling for TipTap component toolbar buttons when the buttons are in an active state.

GitHub Issue: None

Changes

  • Fix dark mode style for TipTap component toolbar buttons
  • Tweak the grammar of the notes refresh button tooltip

Screenshots / Videos Showing UI Changes (if applicable)

Jim __ Caleb _ Oct 31_ 2024

Testing Strategy

  1. Select dark mode
  2. Create some note text
  3. Style it and notice that the toolbar buttons are all still legible even in dark mode

Concerns

None

@jhodapp jhodapp added enhancement Improves existing functionality or feature bug fix Fixes a specific Issue labels Nov 1, 2024
@jhodapp jhodapp added this to the 1.0-rc1 milestone Nov 1, 2024
@jhodapp jhodapp requested a review from qafui November 1, 2024 00:21
@jhodapp jhodapp self-assigned this Nov 1, 2024
@jhodapp jhodapp merged commit 27039cb into main Nov 1, 2024
1 check passed
@jhodapp jhodapp deleted the adjust_tiptap_editor_dark_mode_styling branch November 1, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixes a specific Issue enhancement Improves existing functionality or feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants