Convert numpy scalars to native python objects before sending to yaml dump #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm61
approved these changes
Apr 17, 2023
andyfaff
reviewed
Apr 18, 2023
orsopy/fileio/base.py
Outdated
| @@ -431,6 +431,9 @@ def represent_data(self, data): | |||
| elif isinstance(data, datetime.datetime): | |||
| value = data.isoformat("T") | |||
| return super().represent_scalar("tag:yaml.org,2002:timestamp", value) | |||
| elif (not np.shape(data)) and hasattr(data, "item"): | |||
There was a problem hiding this comment.
how about elif (np.isscalar(data) and hasattr(data, "item"):?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up when trying to save values from Scipp variables to an Orso file.
In recent versions of Scipp, var.value() now returns numpy types, e.g.
np.float64instead ofpythonfloat.We use the
item()method to convert them to a python type before sending to yaml which cannot handle the numpy scalars.