Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Able to pinch-to-zoom on elements outside of canvas #75

Closed
nwittwer opened this issue Oct 3, 2018 · 1 comment
Closed

Bug: Able to pinch-to-zoom on elements outside of canvas #75

nwittwer opened this issue Oct 3, 2018 · 1 comment
Labels
Type: Bug Something isn't working

Comments

@nwittwer
Copy link
Collaborator

nwittwer commented Oct 3, 2018

Problem:
On touch/trackpad devices, you can pinch-to-zoom on top of an element that's not the canvas—such as the toolbar—and it will zoom the entire page content.
@nwittwer nwittwer added the Type: Bug Something isn't working label Oct 3, 2018
@nwittwer
Copy link
Collaborator Author

nwittwer commented Oct 3, 2018 •
edited
Loading

This one appears to be harder than it looked.

  1. (Done) The majority of the issue seems to be solved by changing the scroll handler element to <main>, which contains the toolbar and elements that were being zoomed past before.

  2. (Not done: moving this to a new issue Bug: Pinch-to-zoom on an iFrame can zoom past the app foreground #82) Because there's iframes (which have their own <head> with potentially different scale settings, it's really hard to prevent the whole app from zooming in when you pinch-to-zoom on top of iframes.

@nwittwer nwittwer mentioned this issue Oct 3, 2018
Merged
@nwittwer nwittwer closed this as completed Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nwittwer