History management for android #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for android. This follows the usage recommended at https://developer.android.com/reference/androidx/webkit/WebViewAssetLoader to avoid an issue where assets referred to by file:// urls would receive a permissions error and never be passed to shouldInterceptRequest in sufficiently high API levels. It may be appropriate to expose a method to use a different base URI, which could simplify CORS for android apps in some use cases, and additionally a full conversion to WebViewAssetLoader might be reasonable.
Also exposes the external updates from manageHistory, to allow additional behavior on "back" and "forward" such as skipping redirected routes when going backwards.
|
Also includes the change to https://appassets.androidplatform.net for assets. |
alexfmpe
reviewed
Apr 12, 2023
| @@ -87,7 +86,7 @@ public WebResourceResponse shouldInterceptRequest (WebView view, WebResourceRequ | |||
|
|
|||
| @Override | |||
| public boolean shouldOverrideUrlLoading(WebView view, String url) { | |||
| if( url != null && !url.startsWith("http://") && !url.startsWith("https://") && !url.startsWith("file://")) { | |||
| if( url != null && !url.startsWith("http://appassets.androidplatform.net") && !url.startsWith("https://appassets.androidplatform.net") && !url.startsWith("file://")) { | |||
There was a problem hiding this comment.
Shouldn't this bit be included in #452 ?
Pre-existing, but it's odd that above scheme/encodedAuthority are used but here startsWith is used. Maybe we want this de-duplicated
luigy
reviewed
Jun 28, 2023
| @@ -76,17 +83,24 @@ run jsm = do | |||
| continueWithCallbacks $ def | |||
| { _activityCallbacks_onCreate = \_ -> do | |||
| a <- getHaskellActivity | |||
| let startPage = fromString "file:///android_asset/index.html" | |||
| let startPage = fromString "https:///appassets.androidplatform.net/index.html" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the "back" button in android, adds a function to trigger platform-dependent "back" handling (which on Android includes exiting the app if the history is empty), and extends manageHistory slightly to allow additional behavior on external history navigation such as skipping updates that would now reroute when going backwards.