[bugfix] Fix error in fixture resolution when multiple fixtures of the same class are instantiated with different variables #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @tom91136, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2024-12-05 19:55:42 UTC |
|
CI looks good from what I can see |
vkarak
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Thanks for the fix, it's correct. I've simplified the unit tests by moving your test case to unittests/resources/checks_unlisted/fixtures_complex.py which is already run by the unit tests for verifying the fixture resolution.
I've also rebased your PR on master.
vkarak
changed the title
|
Amazing, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where multiple fixtures of the same class with different variables causes the following error:
Local testing looks regression free; I've also added an additional test case for the bug.
Fixes #3285.