Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual query methods for new ORM params #1402

Closed
4 tasks
Tracked by #972
ryanchristo opened this issue Aug 24, 2022 · 0 comments · Fixed by #1423
Closed
4 tasks
Tracked by #972

Individual query methods for new ORM params #1402

ryanchristo opened this issue Aug 24, 2022 · 0 comments · Fixed by #1423
Assignees
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Feature New feature or request

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Aug 24, 2022

Summary

Related to #1363

Currently paramaters associated with the core package are available to query with QueryParams and parameters associated with the basket and marketplace submodules are not. The basket and marketplace params each have their own queries.

We should add queries for individual core params and consider adding basket and marketplace params to the existing struct so that we can include them in QueryParamsResponse. We will be migrating away from using the Params struct but this is currently misleading in its current state where only core params are returned when querying for params.

Problem Definition

When a user queries for ecocredit params, they expect to receive a response with all ecocredit params (not just core params).

Proposal

Add individual queries for core params and add basket and marketplace params to deprecated core Params struct.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ryanchristo ryanchristo added the Scope: x/ecocredit Issues that update the x/ecocredit module label Aug 24, 2022
@ryanchristo ryanchristo added this to the v5.0 - Titicaca Upgrade milestone Aug 24, 2022
@ryanchristo ryanchristo added the Type: Feature New feature or request label Aug 24, 2022
@aleem1314 aleem1314 self-assigned this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants