-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module graph missing links #51
Comments
I suspect #34 is just not finished yet. I tried copying the "example-lib-edition-2018" out (of the workspace) and generating the graph from it:
It produced the following picture: It looks to be missing all the back edges ("submodule" -> "A", "subsubbmodule" -> "submodule", "A"). |
One issue that I realized here is that cargo-modules doesn't even realize that
I don't yet understand the whole picture. Maybe @regexident you can shed some light on it? |
Before Rust 2018 the complexity of name/module resolution reasonably simple. @muhuk has been spearheading most of the efforts to add full support for Rust 2018, with me mostly doing code review and joining in on discussions on implementation details. In light of the recent "library-ification" by the Rust compiler team I more and more wonder if it wouldn't make sense to tap into some of the logic/crates that are falling out of these efforts, the great work @matklad is doing with rust-analyzer in particular, such as ra_hir, which might be able to solve the whole name resolution issue for us for free. |
This should now be fixed with #66 having been merged. 🎉 😃 |
Hi all! This is one great project, and I'm looking forward to use to for good.
Just trying it on WebRender, I'm missing quite a few links in the generated module graph:
This was generated via the following command, using the code from #50 :
I removed the top-level
Cargo.toml
to convince it that it's not a cargo workspace (otherwise it doesn't work at all, see #8 (comment)).It shows the graph to be pretty flat, even though the modules clearly depend on each other a lot. For example, no arrows originate from
batch
module, even though it clearly uses a whole bunch of stuff.Is this a known issue? Is it related to 2018 edition (cc @muhuk)? Anything I could help with to investigate?
The text was updated successfully, but these errors were encountered: