Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dist files from source control #676

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Remove dist files from source control #676

merged 4 commits into from
Nov 12, 2024

Conversation

rreusser
Copy link
Member

@rreusser rreusser commented Nov 12, 2024

Dist files have not been rebuilt in a long time. I think they should be removed from source control and only published in the npm module, especially since there is nothing (a test, a script run on push) to enforce they are actually built. The result is that they're present but likely to be wrong.

To remove friction, I've elected to preserve the type definitions in dist, though they could be moved to a types directory.

The files are still published to npm and may be retrieved from: https://unpkg.com/browse/regl/dist/

If this causes any problems (people retrieving outdated source files directly from github???), it can be reverted.

@rreusser rreusser changed the title Rebuild dist Remove dist files from source control Nov 12, 2024
@rreusser
Copy link
Member Author

rreusser commented Nov 12, 2024

Oh, I see the typescript build process just cps from ./ to ./dist. I'm just going to remove it from dist as well then. I'm not aware of a good reason anyone should be relying on dist/ of the git repo rather than obtaining dist from a more reliable source like npm or unpkg, but please correct me if I'm wrong and it can easily be restored.

@rreusser rreusser merged commit b59bac5 into main Nov 12, 2024
1 check passed
@rreusser rreusser deleted the rebuild-dist branch November 12, 2024 19:02
@rreusser rreusser mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant