Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly aggregation for inc hosp truth data within load_truth() does not work #401

Open
nikosbosse opened this issue Jan 10, 2024 · 2 comments
Assignees

Comments

@nikosbosse
Copy link
Collaborator

I was trying the following but only got daily data.

load_truth("HealthData", target_variable = "inc hosp", temporal_resolution = "weekly", location = "United States")

I suspect the issue is in load_from_hub_repo(). Specifically, this line

truth_data <- aggregate_to_weekly(truth_data)

is never reached if hub[1] is not "ECDC". Is the nesting level of the if statement correct?

Running aggregate_to_weekly() on the output works just fine.

@nikosbosse nikosbosse changed the title Weekly aggregation for inc hosp truth data does not work Weekly aggregation for inc hosp truth data within load_truth() does not work Jan 10, 2024
@nikosbosse
Copy link
Collaborator Author

In light of #402 this might just be a documentation issue (i.e. I could see why there is no weekly truth data if there is no weekly forecast)

@nickreich
Copy link
Member

This is not just a documentation issue, as the hospitalization data are available as daily counts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants