Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong request time in access log when the connection is dropped #1157

Closed
wants to merge 1 commit into from

Conversation

marcioapm
Copy link
Contributor

No description provided.

@s-ludwig
Copy link
Member

I wonder if we don't have a larger issue here. Not calling finalize() not only means that the request time isn't properly recorded, but also that we potentially leak resources. Do you have an exact reproduction recipe for this?

@marcioapm
Copy link
Contributor Author

I believe it's happening mostly when refreshing while loading.
If you have a route that takes slightly longer to serve, press refresh a few times, not letting it finish and it should reproduce.

@s-ludwig s-ludwig closed this in 4d4256f Jun 29, 2015
@s-ludwig
Copy link
Member

Okay, I reproduced it and now finalize() is simply always called. I've added some checks to avoid additional log noise/exceptions.

@marcioapm
Copy link
Contributor Author

Good stuff! Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants