Various fixes #207
Merged
Various fixes #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parse function takes a ref array, and does not fail if only part of the string was parsed. This is not what we seem to want to do here.
|
Gah! That's an awful lot of fixes, I hope most of them are just due to better diagnostics in DMD master ;) I'll properly fix the HTTP dist stuff right away. And, more importantly, I hope that the CI system will be back working in a few days (had to drop Jenkins some time ago because of continuous harharhar issues with it, that just randomly cropped up and went away). It would of course also be great to have DMD nightlies, as I actually intended to compile a current DMD to fix some compilation errors two weeks ago, but then forgot about it after it didn't compile right away... Anyway, thanks a lot for the fixes! I'll merge and retest my stuff WRT the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's Vladimir! :)
Someone with a better understanding of Vibe threading/internals should have a look at a proper fix of TCPListenOptions.distribute in libevent2.