add port to HTTPServerRequest.fullURL

[extrawurst]

No description provided.

[s-ludwig]

Can you do a rebase of your branch against the main master branch and drop the first two commits? Especially the merge commit contains a lot of changes that otherwise pollute the history. If you want, I can of course also quickly replicate your change locally (I don't want to cause time-wasting git work).

[extrawurst]

I did rebase with you master branch, but i have no idea how to drop the two commits :( (i am kinda new to git)

[s-ludwig]

if you do git rebase -i remotes/upstream/master, where upstream is the rejectedsoftware/vibe.d remote, you can leave out any commit by not marking it as picked. The same works with TortoiseGIT's rebase dialog if you are on Windows. Take that with a grain of salt, though, as I'm not really a git wizard either.

[extrawurst]

I don't get it... i am about to wipe my fork and redo it :D

[s-ludwig]

Hm.. that should work, too, actually ;) Do a "git pull remotes/upstream/master && git reset remotes/upstream/master" and you should have the all commits wiped (again, considering that "upstream" is the proper remote name), but the changes still left in the working tree. Those then just need to be committed again.

But before you do everything from scratch, I'd say I'll just do the commit locally.

[s-ludwig]

But wait a minute, the code is actually not correct. It should be the server port instead of the client port (the one from HTTPServerSettings), but only be set if "X-Forwarded-Host" is not set. The client port is the usually automatically assigned port on the browser side of the connection, which is not really useful in most cases.