Interrupting tasks in different threads assert bug

[magicl]

Assert in core.d should also check for 'null'

    assert(caller.thread is this.thread && 
           caller.thread !is null && 
           this.thread !is null, "Interrupting tasks in different threads is not yet supported.");

[magicl]

A bit quick there.. This makes it work better. Case (if I remember correctly) is when the main 'task' has not been created by vibe.. 'thread' is null

assert(caller.thread is this.thread ||
           caller.thread is null ||
           this.thread is null, "Interrupting tasks in different threads is not yet supported.");

[magicl]

Is this an ok fix? In that case, I can submit a pull-request for it..

[s-ludwig]

I've used assert(caller != Task.init) to assert that the caller is a valid task. This needs to be the case, because the interrupted task gets resumed and expects to be run within a running event loop.

With some effort it would be possible to make interruption from foreign threads and from outside of the event loop work, too.

[magicl]

I have an event-loop run in a thread created outside of vibed. In this thread, I run the event loop, but also do other things. If I try to interrupt a task from the thread (outside any of the tasks spawned by the thread), I get this assert.. How can I fix this? It is not an invalid case, since I only interrupt tasks that are spawned by the same thread.

[s-ludwig]

So do you use a manual processEvents style event loop, so that you can still call other things while it is running? I didn't think of this, but it should be safe to make an exception for that.

[magicl]

Yes, I use 'processEvents'. Thanks. I will try it out when the next release comes.

[s-ludwig]

You could also try it out right now by running dub upgrade --prerelease to get the latest 0.7.20-beta.1.