Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added convenience method for appending to a file... #489

Merged
merged 2 commits into from
Feb 2, 2014
Merged

added convenience method for appending to a file... #489

merged 2 commits into from
Feb 2, 2014

Conversation

extrawurst
Copy link
Contributor

...(just like nodejs's fs.appendFile)

@etcimon
Copy link
Contributor

etcimon commented Jan 31, 2014

Doc doesn' say what happens if the file is locked?

@extrawurst
Copy link
Contributor Author

In the end it simply uses openFile and the docs of that also don't state what happens when the file is locked

@s-ludwig
Copy link
Member

s-ludwig commented Feb 1, 2014

Agreed, it will throw an exception like almost any other function when an error occurs. I hope that D/Druntime/Phobos will get a standard exception hierarchy at some point not too distant in the future. When that happens, I'll use proper specialized exception types and document everything, but right now I don't want to create an own, incompatible exception hierarchy.

@s-ludwig
Copy link
Member

s-ludwig commented Feb 1, 2014

The only change that I'd still make is to call it appendToFile to make it grammatically sound.

@extrawurst
Copy link
Contributor Author

done ;)

@s-ludwig
Copy link
Member

s-ludwig commented Feb 2, 2014

Thanks!

s-ludwig added a commit that referenced this pull request Feb 2, 2014
added convenience method for appending to a file...
@s-ludwig s-ludwig merged commit d8550ef into vibe-d:master Feb 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants