Adding convenience method to parse Redis version

[fabsi88]

No description provided.

[s-ludwig]

Thanks! I don't have a Redis installation to test, so I was wondering if all lines of the info string are of the form "key: value" and if it would be safer to iterate over all lines to find the one with "redis_version" instead of assuming the second line. Or does the spec define that the version must be there anyway?

[fabsi88]

Np! Referring to the documentation of Redis (http://redis.io/commands/info) it has to be on line 2 in the output of INFO. I also thought about a solution to iterate over all lines but I think this would be some kind of overkill for the version retrievement. Another improvement would be to write a method which returns a specific attribute of the INFO - this would iterate over all lines anyway.

[s-ludwig]

OK according to the docs, it seems like for a fully robust implementation it would be necessary to also parse the section headers. I think a good future idea would be to change the info() method to return a struct that has a string[string] map for each section instead of the raw string.

Until such a more general facility is there, though, the fixed line method should be fine. The only thing I'd change is to rename getVersion() into @property version() (it could also simply be cached after the connection has been established instead of re-requesting it for every call).

[extrawurst]

@s-ludwig is it even possible to name a method "version" in D ? I just tried it does not built on win32 dmd...

[extrawurst]

and a "Version" method would be violating the dlang style guide. I would suggest calling it redisVersion

[s-ludwig]

Of course you are right :) The official convention would be to use version_ in this case. Maybe in this case serverVersion?

[extrawurst]

i vote in favor of redisVersion :)

[s-ludwig]

Considering the original name, I change my vote to redisVersion, too ;)

[s-ludwig]

Okay, looks good to go! Thanks again!

(that Travic CI error can safely be ignored)