Feature/i18n enhancement #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| string key; | ||
| string value; | ||
| } | ||
|
|
||
| string keyToIdentifier(string key) |
There was a problem hiding this comment.
You could just remove the code instead of commenting it.
There was a problem hiding this comment.
I could do that if I get around to plural support before this commit gets pulled.
|
I'd pull this and then remove the commented out code if there are no objections. |
s-ludwig
added a commit
that referenced
this pull request
Jan 16, 2015
|
Okay, thanks! I've removed the commented out code; if necessary, we can always dig it up from the GIT history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some unittests to the translation framework in the vibe.web.web module.
Adding support for the msgctxt tag that can be specified in po files.