Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifactWebpackStatsFile is not used #274

Closed
bramkragten opened this issue Oct 12, 2023 · 3 comments · Fixed by #275
Closed

artifactWebpackStatsFile is not used #274

bramkragten opened this issue Oct 12, 2023 · 3 comments · Fixed by #275

Comments

@bramkragten
Copy link

bramkragten commented Oct 12, 2023

It seems like artifactWebpackStatsFile is never used, but instead webpackStatsFile is used.

Both the documentation and the error logs indicate it should be artifactWebpackStatsFile.

https://github.com/relative-ci/agent-action/blob/master/src/index.ts#L46

@vio
Copy link
Member

vio commented Oct 12, 2023

Hi @bramkragten, thanks for opening an issue!

You are right, artifactWebpackStatsFile is not used anymore. If I remember correctly, it was part of the RC for v2, but we decided that we could reuse webpackStatsFile. Will remove it ;)

@bramkragten
Copy link
Author

Thanks for your quick response, it seems you missed one place though:

Please make sure the value of 'artifactWebpackStatsFile' is correct.

@vio
Copy link
Member

vio commented Oct 12, 2023

Ah 😊 ! Thank you for spotting it!

Fixed it and released 2.1.10 to show the correct error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants