You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just creating this issue to make a note of this. I'm just now converting from JSX routes to the plain object syntax, as well as using dynamic routing. I've got a route below ...
In this case, in the JSX format, you'd not put relay queries prop on the account route if it is not a relay container. You'd put the queries on the detail route (it's a container).
Currently on the plain syntax, I had queries provided to the account route on accident. I was getting the following error ...
QueryAggregator.js:126 Uncaught TypeError: Cannot read property 'displayName' of undefined
That actual error is from some ternary logic within another error. Yes, I'm doing it wrong because I was accidentally providing queries on a route without a component, but perhaps we could use some logic prior to this line of code that warns about a component being undefined, etc. It shouldn't have gotten this far with an undefined component, I don't think?
The text was updated successfully, but these errors were encountered:
I'll fix this, but please just submit a PR for this sort of thing going forward. It's a trivial code change and you clearly already found the call site that's generating the exception.
Just creating this issue to make a note of this. I'm just now converting from JSX routes to the plain object syntax, as well as using dynamic routing. I've got a route below ...
This route only serves the purpose of being the equivalent of ...
In this case, in the JSX format, you'd not put relay
queries
prop on the account route if it is not a relay container. You'd put the queries on the detail route (it's a container).Currently on the plain syntax, I had queries provided to the account route on accident. I was getting the following error ...
That actual error is from some ternary logic within another error. Yes, I'm doing it wrong because I was accidentally providing
queries
on a route without a component, but perhaps we could use some logic prior to this line of code that warns about a component being undefined, etc. It shouldn't have gotten this far with an undefined component, I don't think?The text was updated successfully, but these errors were encountered: