Remove ViewerType pattern from Relay Modern example

[robrobkay51]

I recently came across this comment by Lee Byron which advises against using the Viewer type pattern in GraphQL/Relay applications: lucasbento/graphql-pokemon#1 (comment)

If this is now considered best practice, it would be helpful if all examples within this Repo were updated to reflect the guidelines outlined in the above issue thread.

[wincent]

Thanks for the suggestion, but I don't think we should consider doing this until the new Relay core is out (which has much less hacky support for the Viewer type, and drops existing restrictions around root fields). While it's true that Viewer is somewhat of a Facebook-ism, that doesn't necessarily make it an anti-pattern (I think Lee's language is a bit too strong there); it's a convention that has served us well, is perhaps a bit quirky, and one which perhaps we wouldn't have encouraged if we could go back a few years and design the system from scratch. For a related comment I just made on this, see here.

Having said all that, I am totally happy to remove Viewer from the examples. But let's wait until the new core and APIs are fully rolled out.

[ardalann]

@wincent @leebyron Now that Relay Modern is out, is there an example of this?
The TodoModern example still uses the Viewer field:
https://github.com/relayjs/relay-examples/blob/master/todo-modern/data/schema.js

[wincent]

It would be fine to remove the Viewer type from the modern example if you wanted to. There is no "official" example of making that kind of change yet (if there was, it would be here); for an unofficial example, here's the commit in my blog repo where I got rid of the User and Viewer types once I'd moved to Relay Modern.

Adding a "help wanted" label in case anybody wants to take a stab at this.

[fernandocalsa]

Is this issue still relevant? I'm starting with Relay Modern and I would like to help on this issue, I think it can help me to understand better the framework. I've never worked with GraphQL before so I don't know about Relay Classic. @wincent do you think a beginner can fix this issue?

[sibelius]

you can check this 2 pull requests

https://twitter.com/sseraphini/status/900775274387820544

https://github.com/entria/graphql-dataloader-boilerplate/pull/59
entria/ReactNavigationRelayModern#18

[fernandocalsa]

thank you @sibelius I will try to work on it whenever I have some time :D

[Stephen2]

#88 closes this