Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: latest version not found when patch for older version exists #10

Closed
larsl-net opened this issue Apr 22, 2022 · 1 comment · Fixed by #11
Closed

bug: latest version not found when patch for older version exists #10

larsl-net opened this issue Apr 22, 2022 · 1 comment · Fixed by #11
Labels
bug Something isn't working

Comments

@larsl-net
Copy link
Contributor

larsl-net commented Apr 22, 2022

Describe the bug
Currently I get for rancher as the latest version the 2.5.13, although the latest version is the 2.6.4.

This is probably because the 2.5.13 was the last to be released.

To Reproduce
Use the following config

service:
  rancher/rancher:
    type: github
    url: rancher/rancher
    url_commands:
      - type: regex_submatch
        regex: v([0-9.]+)$
    web_url: https://github.com/rancher/rancher/releases/v{{ version }}
    icon: https://raw.githubusercontent.com/rancher/docs/master/static/imgs/rancher-logo-cow-blue.svg
    status:
      current_version: 2.6.3
      current_version_timestamp: "2022-04-22T20:29:51Z"
      latest_version: 2.5.13
      latest_version_timestamp: "2022-04-22T20:29:51Z"
@larsl-net larsl-net added the bug Something isn't working label Apr 22, 2022
@larsl-net larsl-net changed the title bug: latest version not found when patch for older minor version exists bug: latest version not found when patch for older version exists Apr 22, 2022
@JosephKav JosephKav linked a pull request Apr 23, 2022 that will close this issue
@JosephKav
Copy link
Collaborator

Thanks for noticing and reporting. You were right in the cause being because 2.5.13 was released after 2.6.4. I hadn't accounted for patch versions and just took the newer tags as newer versions. I've now made it (if semantic versioning is enabled and it's a git query) get all the possible versions (if the url_commands pass), then go through and sort them by semVer. With this I did default Service.IgnoreMisses to true as not every tag is a release tag, so lots of warnings would print.

Thanks for posting the config with it, that really helped with my testing and 0.0.1 works with that config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants