fix(error): include service name in notify/webhook error messages #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephKav
force-pushed
the
fix-error-include-service-name
branch
2 times, most recently
from
f032970
to
fe4ef54
Compare
received an error about a webhook failing and only knew the service based on the image used. Add service name for cases without changing images
JosephKav
force-pushed
the
fix-error-include-service-name
branch
from
fe4ef54
to
7dfe971
Compare
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 97.57% 97.57% +0.01%
==========================================
Files 60 60
Lines 4919 4921 +2
==========================================
+ Hits 4799 4801 +2
Misses 88 88
Partials 32 32
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receieved an error about a WebHook failure and realised I only knew the service it was about because of the image used. Here's a fix for cases without that identifier