Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): close latest/deployed version http connections #154

Conversation

JosephKav
Copy link
Collaborator

@JosephKav JosephKav commented Sep 6, 2022

#153

wasn't closing latest/deployed version connections with

defer resp.Body.close

@JosephKav JosephKav added the bug Something isn't working label Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #154 (fab150b) into master (50764f9) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   97.49%   97.64%   +0.16%     
==========================================
  Files          63       63              
  Lines        5239     5241       +2     
==========================================
+ Hits         5107     5117      +10     
+ Misses         96       89       -7     
+ Partials       36       35       -1     
Impacted Files Coverage Δ
service/deployed_version/deployed_version.go 100.00% <100.00%> (ø)
service/latest_version/query.go 98.14% <100.00%> (+0.02%) ⬆️
web/api/v1/websocket-client.go 88.52% <0.00%> (+3.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JosephKav JosephKav merged commit 739c7d8 into master Sep 6, 2022
@JosephKav JosephKav deleted the 153-bug-argus-seems-to-not-close-url-connections-on-latest-deployed-versions-check branch September 6, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: argus seems to not close url connections on latest / deployed versions check.
1 participant