Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notify): get access_token passwords working for matrix #196

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

JosephKav
Copy link
Collaborator

shoutrrr wants matrix://:password@... not matrix://password@...

fixes: #193

shoutrrr wants `matrix://:password@...` not `matrix://password@...`
@JosephKav JosephKav added the bug Something isn't working label Jan 12, 2023
@JosephKav JosephKav linked an issue Jan 12, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #196 (67a04a9) into master (a85d06c) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   97.52%   97.67%   +0.16%     
==========================================
  Files          63       63              
  Lines        5302     5302              
==========================================
+ Hits         5170     5178       +8     
+ Misses         96       89       -7     
+ Partials       36       35       -1     
Impacted Files Coverage Δ
notifiers/shoutrrr/shoutrrr.go 100.00% <100.00%> (ø)
notifiers/shoutrrr/verify.go 100.00% <100.00%> (ø)
testing/shoutrrr.go 96.74% <100.00%> (+0.04%) ⬆️
web/api/v1/websocket-client.go 88.52% <0.00%> (+3.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JosephKav JosephKav merged commit 74282d1 into master Jan 12, 2023
@JosephKav JosephKav deleted the 193-bug-notifications-matrix-requires-username branch January 12, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Notifications (Matrix) requires username
1 participant