Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notify): don't login to matrix to verify (could rate-limit fail) #198

Merged

Conversation

JosephKav
Copy link
Collaborator

@JosephKav JosephKav commented Jan 13, 2023

.Locate logs in on Matrix types. Skip the Locate for them to help against login rate-limiting

2023/01/11 20:25:15 DEBUG: 1/109 org/repo1 Init
2023/01/11 20:25:15 DEBUG: 2/109 org/repo2 Init
2023/01/11 20:25:15 DEBUG: 3/109 org/repo3 Init
2023/01/11 20:25:15 DEBUG: 4/109 org/repo4 Init
2023/01/11 20:25:15 DEBUG: 5/109 org/repo5 Init
...
  org/repo1:
    notify:
      matrix:
        ^ failed to log in: Too Many Requests
  org/repo2:
    notify:
      matrix:
        ^ failed to log in: Too Many Requests
  org/repo3:
    notify:
      matrix:
        ^ failed to log in: Too Many Requests
  org/repo4:
    notify:
      matrix:
        ^ failed to log in: Too Many Requests
  org/repo5:
    notify:
      matrix:
        ^ failed to log in: Too Many Requests

@JosephKav JosephKav added the bug Something isn't working label Jan 13, 2023
@JosephKav JosephKav linked an issue Jan 13, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #198 (a7ece13) into master (81a2a72) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   97.67%   97.67%   +0.01%     
==========================================
  Files          63       63              
  Lines        5307     5309       +2     
==========================================
+ Hits         5183     5185       +2     
  Misses         89       89              
  Partials       35       35              
Impacted Files Coverage Δ
notifiers/shoutrrr/verify.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JosephKav JosephKav merged commit a15437d into master Jan 13, 2023
@JosephKav JosephKav deleted the 195-bug-notifications-matrix-causes-rate-limit-on-startup branch January 13, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Notifications (Matrix) causes rate limit on startup
1 participant