Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): use the semantic_versioning bool on query #270

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

JosephKav
Copy link
Collaborator

(false || "") === "", so semantic_versioning wouldn't have been sent on version refresh queries.
Switch to null-coalesceing operator ??, (false ?? "") === false

@JosephKav JosephKav added the bug Something isn't working label Jun 19, 2023
@JosephKav JosephKav linked an issue Jun 19, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #270 (b35341a) into master (27f04d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          87       87           
  Lines        8180     8180           
=======================================
  Hits         8054     8054           
  Misses         97       97           
  Partials       29       29           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JosephKav JosephKav merged commit fd4e2ae into master Jun 19, 2023
@JosephKav JosephKav deleted the 268-bug-semantic_versioning branch June 19, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: semantic_versioning
1 participant