Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename current_version to deployed_version #64

Merged
merged 1 commit into from
May 23, 2022

Conversation

JosephKav
Copy link
Collaborator

@JosephKav JosephKav commented May 22, 2022

Would have called this deployed_version originally if I'd planned support to monitor deployed services. Makes more sense as it is tracking the deployed_version either through an API, or by triggering update scripts with WebHook(s)

Shouldn't effect existing deployments as I've made it convert current_version* to deployed_version*

@JosephKav JosephKav added the enhancement New feature or request label May 22, 2022
@JosephKav JosephKav linked an issue May 22, 2022 that may be closed by this pull request
@JosephKav JosephKav force-pushed the 56-rename-current_version-to-deployed_version branch 2 times, most recently from 2645e3c to bafb3d1 Compare May 23, 2022 00:02
Would have called this `deployed_version` originally if I'd planned support to monitor deployed services. Makes more sense as it is tracking the `deployed_version` either through an API, or by triggering update scripts with WebHook(s)
Shouldn't effect existing deployments as I've made it convert `current_version*` to `deployed_version*`
@JosephKav JosephKav force-pushed the 56-rename-current_version-to-deployed_version branch from bafb3d1 to ca3d94a Compare May 23, 2022 00:04
@JosephKav JosephKav merged commit 6ca95c1 into master May 23, 2022
@JosephKav JosephKav deleted the 56-rename-current_version-to-deployed_version branch May 23, 2022 00:06
JosephKav added a commit that referenced this pull request May 23, 2022
Would have called this `deployed_version` originally if I'd planned support to monitor deployed services. Makes more sense as it is tracking the `deployed_version` either through an API, or by triggering update scripts with WebHook(s)
Shouldn't effect existing deployments as I've made it convert `current_version*` to `deployed_version*` automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename current_version to deployed_version
1 participant